chore: Use ES6 to write functions#2185
Merged
1 commit merged intomasterfrom Apr 17, 2019
unknown repository
Merged
Conversation
ZYSzys
reviewed
Apr 14, 2019
Member
ZYSzys
left a comment
ZYSzys
left a comment
There was a problem hiding this comment.
Not sure exactly, maybe it's used to replace this
bee3f0d#diff-efd59cd1bdc5c9ac6d0eaa368f1e149fL164 ?
Contributor
|
@ZYSzys Yes, you're right. But I can't remember where we needed the |
Author
|
So this file shouldn't be removed? Well……I didn't find anywhere to refer…… XD |
Member
It's indirectly referenced: Lines 158 to 161 in 2ca6dec |
Use ES6 to write `m.read` and `Object.keys...` functions.
ghost
changed the title
Author
|
Thanks all! I've changed the topic to another submit :) |
ghost
requested a review
from
ZYSzys
approved these changes
Apr 16, 2019
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'json.js' file isn't referred, so remove it.Use ES6 to write functions for 'm.read' and 'Object.keys.forEach' in 'build.js'.